Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add missing data-test-subj tags for discover plugin #9062

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f06a478 from #9049.

* Add data-test-subj for discover
Signed-off-by: Anan Zhuang <[email protected]>
* fix comment
Signed-off-by: Anan Zhuang <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit f06a478)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (be4e262) to head (82222be).
Report is 47 commits behind head on 2.x.

Files with missing lines Patch % Lines
...over/public/application/components/chart/chart.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #9062   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files        3807     3807           
  Lines       91162    91162           
  Branches    14392    14392           
=======================================
+ Hits        55504    55506    +2     
+ Misses      32131    32130    -1     
+ Partials     3527     3526    -1     
Flag Coverage Δ
Linux_1 29.04% <0.00%> (ø)
Linux_2 56.52% <ø> (ø)
Linux_3 37.84% <0.00%> (+<0.01%) ⬆️
Linux_4 30.02% <ø> (ø)
Windows_1 29.06% <0.00%> (ø)
Windows_2 56.48% <ø> (ø)
Windows_3 37.84% <0.00%> (ø)
Windows_4 30.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angle943
Copy link
Collaborator

This PR is redundant if my PR is merged #9049

@abbyhu2000 abbyhu2000 closed this Jan 21, 2025
@github-actions github-actions bot deleted the backport/backport-9049-to-2.x branch January 21, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor failed changeset v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants