Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Add disablePrototypePoisoningProtection configuration #3325

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1a82ae3 from #2992.

Enables the configuration of `disablePrototypePoisoningProtection` by setting
`opensearch.disablePrototypePoisoningProtection`. Enables users to store
protected logs that include reserve words from JS without the
OpenSearch JS client throwing errors.

We should still consider transforming unsafe data values if a bad actor
attempts to prototype pollute the cluster.

More information:
https://web.archive.org/web/20200319091159/https://hueniverse.com/square-brackets-are-the-enemy-ff5b9fd8a3e8?gi=184a27ee2a08

Related issue:
#1777

Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
(cherry picked from commit 1a82ae3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@ananzh
Copy link
Member

ananzh commented Jan 25, 2023

This backport fail due to disablePrototypePoisoningProtection?: boolean | 'proto' | 'constructor'; doesn’t exist in "@elastic/elasticsearch": "7.10.0-rc.1" which is what we use in 1.x

Close this backport PR

@ananzh ananzh closed this Jan 25, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-2992-to-1.3 branch August 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant