Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Builder] Persist agg when switching among area, line, histogram vis type #3158

Conversation

abbyhu2000
Copy link
Member

Description

Persist aggregation parameters when switching among area, line and histogram vis types.

Metric, segment, group and split schema will be mapped accordingly. Radius schema will be dropped since only Line vis type has this schema.

Metric and table vis type do not participate in the agg param persistence for now.

Issues Resolved

#3157

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 added vis builder v2.5.0 'Issues and PRs related to version v2.5.0' labels Dec 29, 2022
@abbyhu2000 abbyhu2000 self-assigned this Dec 29, 2022
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000 abbyhu2000 force-pushed the persist_agg_when_switching_vis_type branch from 6ae533c to 7d3bb5b Compare December 29, 2022 21:31
@abbyhu2000 abbyhu2000 marked this pull request as ready for review December 29, 2022 21:32
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner December 29, 2022 21:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #3158 (79a4b3b) into main (303e3bd) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3158      +/-   ##
==========================================
- Coverage   66.53%   66.46%   -0.08%     
==========================================
  Files        3200     3201       +1     
  Lines       61249    61264      +15     
  Branches     9426     9430       +4     
==========================================
- Hits        40753    40720      -33     
- Misses      18247    18259      +12     
- Partials     2249     2285      +36     
Flag Coverage Δ
Linux 66.46% <33.33%> (-0.02%) ⬇️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uilder/public/application/components/right_nav.tsx 11.11% <0.00%> (-2.23%) ⬇️
...plication/utils/state_management/shared_actions.ts 100.00% <ø> (ø)
...tion/utils/state_management/visualization_slice.ts 36.11% <ø> (ø)
...c/application/utils/use/use_persisted_agg_param.ts 41.66% <41.66%> (ø)
src/dev/build/lib/get_build_number.ts 57.14% <0.00%> (-42.86%) ⬇️
src/setup_node_env/harden/child_process.js 38.46% <0.00%> (-38.47%) ⬇️
packages/osd-cross-platform/src/path.ts 51.21% <0.00%> (-34.15%) ⬇️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 91.30% <0.00%> (-8.70%) ⬇️
src/dev/build/lib/config.ts 79.41% <0.00%> (-5.89%) ⬇️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 5, 2023
@abbyhu2000
Copy link
Member Author

Close this PR as the implementation for the new proposal is here: #3495

@abbyhu2000 abbyhu2000 closed this Mar 3, 2023
@abbyhu2000 abbyhu2000 deleted the persist_agg_when_switching_vis_type branch June 30, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants