-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis Builder] Persist agg when switching among area, line, histogram vis type #3158
Closed
abbyhu2000
wants to merge
7
commits into
opensearch-project:main
from
abbyhu2000:persist_agg_when_switching_vis_type
Closed
[Vis Builder] Persist agg when switching among area, line, histogram vis type #3158
abbyhu2000
wants to merge
7
commits into
opensearch-project:main
from
abbyhu2000:persist_agg_when_switching_vis_type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
6ae533c
to
7d3bb5b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3158 +/- ##
==========================================
- Coverage 66.53% 66.46% -0.08%
==========================================
Files 3200 3201 +1
Lines 61249 61264 +15
Branches 9426 9430 +4
==========================================
- Hits 40753 40720 -33
- Misses 18247 18259 +12
- Partials 2249 2285 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 task
Close this PR as the implementation for the new proposal is here: #3495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Persist aggregation parameters when switching among area, line and histogram vis types.
Metric, segment, group and split schema will be mapped accordingly. Radius schema will be dropped since only Line vis type has this schema.
Metric and table vis type do not participate in the agg param persistence for now.
Issues Resolved
#3157
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr