[Backport 2.x] Trim trailing slashes before checking no-restricted-path rule #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
kristenTian
previously approved these changes
Dec 9, 2022
|
@kristenTian arent we going to verify if the windows tests pass? |
kavilla
previously approved these changes
Dec 17, 2022
…true (#3020) `no-restricted-paths` compares source files and import statements, and their membership in restricted zones. However, when `allowSameFolder` is true, it failed to remove a trailing slash before validation which results in a false-positive. Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]> (cherry picked from commit 8732b1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
force-pushed
the
backport/backport-3020-to-2.x
branch
from
47c2505 to
692af42
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #3054 +/- ##
==========================================
+ Coverage 66.61% 66.65% +0.04%
==========================================
Files 3219 3219
Lines 61531 61531
Branches 9431 9431
==========================================
+ Hits 40986 41016 +30
+ Misses 18303 18277 -26
+ Partials 2242 2238 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abbyhu2000
approved these changes
Jan 6, 2023
manasvinibs
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8732b1c from #3020.