Skip to content

Commit

Permalink
Fix query editor cursor alignment by removing monaco css overrides (#…
Browse files Browse the repository at this point in the history
…8912) (#8913)

* Fix query editor cursor alignment by removing monaco css overrides

Monaco editor computes the cursor position internally and does not account for any css overrides
that change the position of the line (padding, margin, etc). This change removes the css override
while we implement these styles with the monaco api directly.



* Changeset file for PR #8912 created/updated

* fix linting



---------





(cherry picked from commit f110637)

Signed-off-by: Daniel Rowe <[email protected]>
Signed-off-by: Daniel Rowe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rowe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
  • Loading branch information
4 people authored Jan 21, 2025
1 parent 339d07d commit 24a1667
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/8912.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Ensure query editor cursor is aligned with text ([#8912](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8912))
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
padding: 0 $euiSizeXS;
}

.view-lines {
padding: 0 $euiSizeXS;
}

.monaco-scrollable-element {
border-radius: 0 $euiSizeXS 0 0;
}
Expand Down

0 comments on commit 24a1667

Please sign in to comment.