-
Notifications
You must be signed in to change notification settings - Fork 959
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests
The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved #3975 Signed-off-by: ananzh <[email protected]>
- Loading branch information
Showing
2 changed files
with
7 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,7 +74,9 @@ if (majorVersion) { | |
if (process.argv.includes('--install')) { | ||
console.log(`Installing chromedriver@^${majorVersion}`); | ||
|
||
spawnSync(`yarn add --dev chromedriver@^${majorVersion}`, { | ||
// TODO: Temporary fix to install chromedriver 112.0.0; revert this once Node is bumped to 16+. | ||
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3975 | ||
spawnSync('yarn add --dev [email protected]', { | ||
stdio: 'inherit', | ||
cwd: process.cwd(), | ||
shell: true, | ||
|
@@ -90,10 +92,9 @@ if (majorVersion) { | |
}); | ||
rl.on('line', (line) => { | ||
if (line.includes('"chromedriver": "')) { | ||
line = line.replace( | ||
/"chromedriver":\s*"[~^]?\d[\d.]*\d"/, | ||
`"chromedriver": "^${majorVersion}"` | ||
); | ||
// TODO: Temporary fix to install chromedriver 112.0.0; revert this once Node is bumped to 16+. | ||
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3975 | ||
line = line.replace(/"chromedriver":\s*"[~^]?\d[\d.]*\d"/, `"chromedriver": "112.0.0"`); | ||
upgraded = true; | ||
} | ||
writeStream.write(line + '\n', 'utf8'); | ||
|