Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial compilation #3

Merged
merged 20 commits into from
Aug 15, 2021
Merged

Add initial compilation #3

merged 20 commits into from
Aug 15, 2021

Conversation

znicholls
Copy link
Contributor

@znicholls znicholls commented Aug 14, 2021

@danielhuppmann this should be enough to get us started. It's basically just a big dump of data but I think gives us a base we can then improve on.

I've made issues for everything I can think of that is missing (really only using the nomenclature package as that also handles units checking), see #2

@znicholls
Copy link
Contributor Author

(p.s. I will make PRs from forks in future)

Copy link
Collaborator

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a start, a few comments inline, and suggestion to use the following as a header for all notebooks:

# AR6 WG1 - SPM.x

This notebook reproduceds parts of **Figure SPM.x** of the IPCC's *Working Group I contribution to the Sixth Assessment Report* ([AR6 WG1](https://www.ipcc.ch/assessment-report/ar6/)).

The data supporting the SPM figure is published under a Creative Commons CC-BY license at 
the [Centre for Environmental Data Analyis (CEDA)](https://catalogue.ceda.ac.uk/uuid/ae4f1eb6fce24adcb92ddca1a7838a5c).

This notebook uses a version of that data which was processed for interoperability with the format used by IPCC WG3, the so-called IAMC format.  
The notebook is available under an open-source [BSD-3 License](https://github.com/openscm/AR6-WG1-Data-Compilation/blob/main/LICENSE) in the [openscm/AR6-WG1-Data-Compilation](https://github.com/openscm/AR6-WG1-Data-Compilation) GitHub repository.

The notebook uses the community Python package [scmdata|(https://scmdata.readthedocs.io), <a short blurb about the package>.

@znicholls
Copy link
Contributor Author

suggestion to use the following as a header for all notebooks

Nice, updated the notebooks and updated the naming based on our offline discussion.

Copy link
Collaborator

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, many thanks! The link to scmdata in the notebooks is formatted incorrectly - please fix, then good to be merged!

@znicholls
Copy link
Contributor Author

The link to scmdata in the notebooks is formatted incorrectly

fml

@znicholls znicholls merged commit 1a56682 into main Aug 15, 2021
@znicholls znicholls deleted the initial-figures branch August 15, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants