Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOFTWARE-6017: ospool-ep/osg-24 #178

Merged
merged 1 commit into from
Oct 28, 2024
Merged

SOFTWARE-6017: ospool-ep/osg-24 #178

merged 1 commit into from
Oct 28, 2024

Conversation

mwestphall
Copy link
Contributor

  • I can rebase this into a single commit if preferred, history isn't too terribly long though

@mwestphall mwestphall requested a review from brianhlin October 22, 2024 19:48
brianhlin
brianhlin approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd prefer squashing the WIP commits in the future but I'm ok rushing this through as is

@mwestphall
Copy link
Contributor Author

@brianhlin squashed the commits. Would you be able to merge this PR in? I still don't have permissions.

@brianhlin brianhlin merged commit 9aa7b84 into master Oct 28, 2024
19 of 34 checks passed
@brianhlin brianhlin deleted the SOFTWARE-6017-osg24 branch October 28, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhlin brianhlin brianhlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwestphall @brianhlin