Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex console warning errors in template editor #1271

Closed
danyill opened this issue Jun 22, 2023 · 1 comment · Fixed by #1273 or #1543
Closed

Regex console warning errors in template editor #1271

danyill opened this issue Jun 22, 2023 · 1 comment · Fixed by #1273 or #1543
Assignees
@danyill
Labels
Kind: Bug Something isn't working

Comments

@danyill
Copy link
Collaborator

danyill commented Jun 22, 2023 •
edited
Loading

Describe the bug

Related to #1265 I don't think all the regex strings are right yet.
I cleared my cache, opened the Templates plugin, clicked on an item and I see console warnings.

To Reproduce

Steps to reproduce the behavior:

  1. Open a file in OpenSCD with DataTypeTemplate definitions.
  2. Add the Templates editor and open it.
  3. Click on a DOType, the "Edit DOType" screen appears.
  4. See console warning.

Expected behavior

No warnings if we've moved with upstream.

Screenshots

image

Desktop (please complete the following information):

  • OS: Linux Ubuntu 23.04.
  • Browser: Chrome
  • Version: 113.0.5672.92 (Official Build) (64-bit)
@danyill danyill added the Kind: Bug Something isn't working label Jun 22, 2023
@danyill
Copy link
Collaborator Author

danyill commented Jun 22, 2023

I think I see the problem, we have not updated the regexes associated with limits for wizards. I shall do a PR.

@danyill danyill self-assigned this Jun 22, 2023
danyill added a commit to danyill/open-scd that referenced this issue Jun 22, 2023
@danyill
fix(wizards/foundation): Escape limit regexes, closes openscd#1271
3aa2b13
@danyill danyill mentioned this issue Jun 22, 2023
Merged
danyill added a commit that referenced this issue Jun 26, 2023
@danyill
fix(wizards/doTypes): Adjust regular expressions for v flag in templa…
baa9bdc 
…te editor (#1273)

fix(wizards/foundation): Escape limit regexes, closes #1271
@github-actions github-actions bot mentioned this issue Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danyill danyill

Labels
Kind: Bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@danyill