Added feature for allowing the user to fit an external image in the template keeping the aspect ratio #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate keeping the aspect ratio
|
Good morning, Is it expected that this PR will be merged soon? |
|
Hello, I have had this PR open for the last three years. @pascalleclercq would you have time to look over this PR? |
pascalleclercq
approved these changes
Jan 25, 2025
|
@VladFlorinIlie Looks good to me, do you want me to merge It and create a new release ? |
That would be great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the feature described in: #158
It is enough to do "setResize(true)" on the desired image and it will be resized to fit the template while keeping the aspect ratio of the replacement image.