Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode Lombok 1.18.37 version #5025

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

knutwannheden
Copy link
Contributor

Only use this version of Lombok.

Only use this version of Lombok.
@@ -124,13 +124,13 @@ private ReloadableJava11Parser(
Options.instance(context).put("should-stop.ifError", "GENERATE");

LOMBOK:
if (classpath != null && classpath.stream().anyMatch(it -> it.toString().contains("lombok"))) {
if (classpath != null && classpath.stream().anyMatch(it -> it.toString().contains("lombok-1.18.37"))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the below || part.toString().contains("rewrite-java-lombok" will trigger now that this specifically looks for -1.18.37. Any insights there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Lombok itself isn't on the classpath, we can skip this entire code path.

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved already, but one question just above. ☝🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants