-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amending YAML parser to add support for tags #4934
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
- lines 240-241
- rewrite-maven/src/test/java/org/openrewrite/maven/internal/MavenPomDownloaderTest.java
- lines 1278-1278
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
- lines 240-241
- rewrite-maven/src/test/java/org/openrewrite/maven/internal/MavenPomDownloaderTest.java
- lines 1278-1278
Added in 6344b6a |
Renamed the field to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantDependencyVersions.java
- lines 240-241
- rewrite-maven/src/test/java/org/openrewrite/maven/internal/MavenPomDownloaderTest.java
- lines 1278-1278
Added in adf3fbb |
What's changed?
Adding support for tags in YAML, e.g.
!Dynamo
is a tag here.What's your motivation?
Observed in real-life YAMLs that they sometimes use tags.
Currently they have been accidentally supported in some cases. E.g. for scalars we used to consider
!Dynamo Title
to be the value.Anything in particular you'd like reviewers to focus on?
The LST model for YAML has been amended to include two new fields called
tag
inScalar
andSequence
. Which is not fully backward compatible. E.g. if someone has a recipe which doesnew Yaml.Scalar(...)
, the code will no longer compile for 1 extra argument missing.Not sure how do we provide coverage for these scenarios.