Add stricter requirements for expected failure

openprocurement · Oct 25, 2016 · 654276a · 654276a
1 parent 8e82b4c
commit 654276a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/op_robot_tests/tests_files/brokers/openprocurement_client.robot b/op_robot_tests/tests_files/brokers/openprocurement_client.robot
@@ -191,7 +191,15 @@ Library  openprocurement_client_helper.py
   ...      Remove From Dictionary  ${tender.data}  enquiryPeriod
   ${tender}=  set_access_key  ${tender}  ${USERS.users['${username}'].access_token}
   ${tender}=  Call Method  ${USERS.users['${username}'].client}  patch_tender  ${tender}
-  Compare Objects  ${prev_value}  ${USERS.users['${username}'].tender_data['${fieldname}']}
+  # The two values should differ. If they are equal, then probably the server refused to,
+  # or failed to modify the value of a field, so this keyword should instantly fail.
+  ${new_value}=  Get From Object  ${USERS.users['${username}'].tender_data.data}  ${fieldname}
+  Compare Objects
+  ...      ${prev_value}
+  ...      ${new_value}
+  ...      msg=Failed to modify "${fieldname}"
+  ...      values=${False}
+  ...      inequal=${True}
   Set_To_Object   ${USERS.users['${username}'].tender_data}   ${fieldname}   ${fieldvalue}
 
 ##############################################################################

diff --git a/op_robot_tests/tests_files/keywords.robot b/op_robot_tests/tests_files/keywords.robot
@@ -409,7 +409,10 @@ Log differences between dicts
 
 
 Перевірити неможливість зміни поля ${field} тендера на значення ${new_value} для користувача ${username}
-  Require Failure  ${username}  Внести зміни в тендер  ${TENDER['TENDER_UAID']}  ${field}  ${new_value}
+  Run Keyword And Expect Error
+  ...      Failed to modify "${field}"
+  ...      Run As  ${username}
+  ...      Внести зміни в тендер  ${TENDER['TENDER_UAID']}  ${field}  ${new_value}
 
 
 Звірити дату тендера