Replace PublicUserType with models.PublicUser type #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlacey
commented
Sep 29, 2024
j4qfrost
approved these changes
Sep 29, 2024
Yeah, this is just how the changes to the model in #354 are going to be used. |
pwdel
approved these changes
Oct 2, 2024
ajlacey
added a commit
that referenced
this pull request
Oct 6, 2024
* Make PublicUser type and embed it into User type * Update User instations to use the PublicUser type * Replace PublicUserType with models.PublicUser type (#355)
j4qfrost
pushed a commit
to j4qfrost/socialpredict
that referenced
this pull request
Oct 6, 2024
* Make PublicUser type and embed it into User type * Update User instations to use the PublicUser type * Replace PublicUserType with models.PublicUser type (openpredictionmarkets#355)
j4qfrost
added a commit
that referenced
this pull request
Oct 7, 2024
* add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards * add frontend file polling for wsl2 * Add test for HandleHTTPError (#278) * add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards --------- Co-authored-by: Osnat Katz Moon <[email protected]> * add failure condition test (#282) * Creation of Market Price Projection API (#277) * Moving test to appropriate location. * Updating, including moving test location. Test not passing due to precision error but generally passing on the terminal up to 6 dits. * market projection handler, not working. * Update market projected probability. * Safe uint conversion. * Updating, adding noop change to push into pipeline. * Update, test passing. * Update, attempting to solve type converstion uint problem. * Adding projected market layout. * Update, still have react JSON parse error but layout added to buyshares. * Market projection updates on buy shares side, upon button press. * Update, change printf to print. * Create SECURITY.md * Adding Fees to Buying and Selling Bets (#287) * Drafting out fees deduction functions and capability. * Attempting working version of initialBetFee function. * Draft adding fees. * Update, adding tests. * Adding working test for GetBetsForMarket * Successful fee util test. * Fees added on backend, tests passing. * Updating such that user record submitted. However fee summing not working yet evidently. * Working fees, at least initial fees. * Updating test scenario passing, made more clear. * Update Dockerfile We need to switch to 3.0.14-1~deb12u2 * Removing logging. * Adding fees, including communicating fees on front end. * totalBetCount to userBetCount so as not to misconstrue meaning. * Simplifying function, test passed. * Simplifying naming. * Updating new function name in test * Changing test to got before want convention. * Update marketid variable * Add combined fee structure for more througough test. * Reverting sale amount to 1 share. * Reversing got want --------- Co-authored-by: Osnat Katz Moon <[email protected]> * Frontend fixes (#286) * fix: fixed the market buttons not showing on mobile * fix: removed trade button on closed market --------- Co-authored-by: Patrick Delaney <[email protected]> * Attempting toa ddress cors related security concern. (#298) * Drafting out reporting stats. * Add support for dependency injection to setup (#301) * Make EconomicsConfig from component structs Auto initialize config Add support to inject config Add support for testing the setup through test doubles Use new fee for placing bets (EachBetFee) * revert * Fix/remove wsl check (#337) * add failure condition test * Add test for HandleHTTPError (#278) * add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards --------- Co-authored-by: Osnat Katz Moon <[email protected]> * add failure condition test (#282) * Creation of Market Price Projection API (#277) * Moving test to appropriate location. * Updating, including moving test location. Test not passing due to precision error but generally passing on the terminal up to 6 dits. * market projection handler, not working. * Update market projected probability. * Safe uint conversion. * Updating, adding noop change to push into pipeline. * Update, test passing. * Update, attempting to solve type converstion uint problem. * Adding projected market layout. * Update, still have react JSON parse error but layout added to buyshares. * Market projection updates on buy shares side, upon button press. * Update, change printf to print. * Create SECURITY.md * Adding Fees to Buying and Selling Bets (#287) * Drafting out fees deduction functions and capability. * Attempting working version of initialBetFee function. * Draft adding fees. * Update, adding tests. * Adding working test for GetBetsForMarket * Successful fee util test. * Fees added on backend, tests passing. * Updating such that user record submitted. However fee summing not working yet evidently. * Working fees, at least initial fees. * Updating test scenario passing, made more clear. * Update Dockerfile We need to switch to 3.0.14-1~deb12u2 * Removing logging. * Adding fees, including communicating fees on front end. * totalBetCount to userBetCount so as not to misconstrue meaning. * Simplifying function, test passed. * Simplifying naming. * Updating new function name in test * Changing test to got before want convention. * Update marketid variable * Add combined fee structure for more througough test. * Reverting sale amount to 1 share. * Reversing got want --------- Co-authored-by: Osnat Katz Moon <[email protected]> * Frontend fixes (#286) * fix: fixed the market buttons not showing on mobile * fix: removed trade button on closed market --------- Co-authored-by: Patrick Delaney <[email protected]> * Attempting toa ddress cors related security concern. (#298) * Drafting out reporting stats. * Add support for dependency injection to setup (#301) * Make EconomicsConfig from component structs Auto initialize config Add support to inject config Add support for testing the setup through test doubles Use new fee for placing bets (EachBetFee) * remove wsl check * remove watcher --------- Co-authored-by: Osnat Katz Moon <[email protected]> Co-authored-by: Patrick Delaney <[email protected]> Co-authored-by: Marko Kovač <[email protected]> Co-authored-by: Arthur <[email protected]> * Feature/frontend vite build (#341) * add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards * add frontend file polling for wsl2 * Add test for HandleHTTPError (#278) * add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards --------- Co-authored-by: Osnat Katz Moon <[email protected]> * add failure condition test (#282) * Creation of Market Price Projection API (#277) * Moving test to appropriate location. * Updating, including moving test location. Test not passing due to precision error but generally passing on the terminal up to 6 dits. * market projection handler, not working. * Update market projected probability. * Safe uint conversion. * Updating, adding noop change to push into pipeline. * Update, test passing. * Update, attempting to solve type converstion uint problem. * Adding projected market layout. * Update, still have react JSON parse error but layout added to buyshares. * Market projection updates on buy shares side, upon button press. * Update, change printf to print. * Create SECURITY.md * Adding Fees to Buying and Selling Bets (#287) * Drafting out fees deduction functions and capability. * Attempting working version of initialBetFee function. * Draft adding fees. * Update, adding tests. * Adding working test for GetBetsForMarket * Successful fee util test. * Fees added on backend, tests passing. * Updating such that user record submitted. However fee summing not working yet evidently. * Working fees, at least initial fees. * Updating test scenario passing, made more clear. * Update Dockerfile We need to switch to 3.0.14-1~deb12u2 * Removing logging. * Adding fees, including communicating fees on front end. * totalBetCount to userBetCount so as not to misconstrue meaning. * Simplifying function, test passed. * Simplifying naming. * Updating new function name in test * Changing test to got before want convention. * Update marketid variable * Add combined fee structure for more througough test. * Reverting sale amount to 1 share. * Reversing got want --------- Co-authored-by: Osnat Katz Moon <[email protected]> * Frontend fixes (#286) * fix: fixed the market buttons not showing on mobile * fix: removed trade button on closed market --------- Co-authored-by: Patrick Delaney <[email protected]> * Attempting toa ddress cors related security concern. (#298) * Drafting out reporting stats. * Add support for dependency injection to setup (#301) * Make EconomicsConfig from component structs Auto initialize config Add support to inject config Add support for testing the setup through test doubles Use new fee for placing bets (EachBetFee) * revert * feat(frontend): Compiles frontend into single js file for performance * forgot merge --------- Co-authored-by: Osnat Katz Moon <[email protected]> Co-authored-by: Patrick Delaney <[email protected]> Co-authored-by: Marko Kovač <[email protected]> Co-authored-by: Arthur <[email protected]> * feat(ci): Add docker creation workflow * separate builds * on branch up * main * correct files * remove syntax check * fix metas * meta access * attestation * separate attestations * latest tag * tag change * caching * buildx and tagging * retag and test cache * tagging * automate on tags * added back for security * feat(ci): Deploy workflow to staging * squashed CI changes * args * Updating documentation (#362) * Update README.md Rewrote README to look more sales-friendly and less plain * Update CONTRIBUTING.md Added instructions for how to name a branch properly and added links to our Issues tab and Code of Conduct * Refactor user model to include private fields explicitly (#353) * Move Email and APIKey to PrivateUser fields, and embed PrivateUser into User * Remove unused field ApiKey from test user * Add documentation comment to ValidateTokenAndGetUser function * Adjust instantiation of user private fields * Remove PrivateUserResponse type for redundancy replace it with models.PrivateUser call. remove helper for getting private info out of the user type. directly embed the private fields into the response. * Refactor public user model (#354) * Make PublicUser type and embed it into User type * Update User instations to use the PublicUser type * Replace PublicUserType with models.PublicUser type (#355) * Adding Kenyon College Logo to Front Page Readme (#364) * Adding image. * updaing contribution guideline and readme again with kenyon name. * Fix/ci pass doc check (#363) * add failure condition test * Add test for HandleHTTPError (#278) * add test for HandleHTTPError undelete * more verbose http codes * Update Dockerfile Now using go 1.23! Tested this on dev, it works * Update compose_dev.sh Prints initial settings as defined in setup.yaml. Added for usability reasons - users keep getting confused about account balance and maximum allowable debt * add failure condition test * formatting and test standards --------- Co-authored-by: Osnat Katz Moon <[email protected]> * add failure condition test (#282) * Creation of Market Price Projection API (#277) * Moving test to appropriate location. * Updating, including moving test location. Test not passing due to precision error but generally passing on the terminal up to 6 dits. * market projection handler, not working. * Update market projected probability. * Safe uint conversion. * Updating, adding noop change to push into pipeline. * Update, test passing. * Update, attempting to solve type converstion uint problem. * Adding projected market layout. * Update, still have react JSON parse error but layout added to buyshares. * Market projection updates on buy shares side, upon button press. * Update, change printf to print. * Create SECURITY.md * Adding Fees to Buying and Selling Bets (#287) * Drafting out fees deduction functions and capability. * Attempting working version of initialBetFee function. * Draft adding fees. * Update, adding tests. * Adding working test for GetBetsForMarket * Successful fee util test. * Fees added on backend, tests passing. * Updating such that user record submitted. However fee summing not working yet evidently. * Working fees, at least initial fees. * Updating test scenario passing, made more clear. * Update Dockerfile We need to switch to 3.0.14-1~deb12u2 * Removing logging. * Adding fees, including communicating fees on front end. * totalBetCount to userBetCount so as not to misconstrue meaning. * Simplifying function, test passed. * Simplifying naming. * Updating new function name in test * Changing test to got before want convention. * Update marketid variable * Add combined fee structure for more througough test. * Reverting sale amount to 1 share. * Reversing got want --------- Co-authored-by: Osnat Katz Moon <[email protected]> * Frontend fixes (#286) * fix: fixed the market buttons not showing on mobile * fix: removed trade button on closed market --------- Co-authored-by: Patrick Delaney <[email protected]> * Attempting toa ddress cors related security concern. (#298) * Drafting out reporting stats. * Add support for dependency injection to setup (#301) * Make EconomicsConfig from component structs Auto initialize config Add support to inject config Add support for testing the setup through test doubles Use new fee for placing bets (EachBetFee) * fix(ci): Doc check skip * not --------- Co-authored-by: Osnat Katz Moon <[email protected]> Co-authored-by: Patrick Delaney <[email protected]> Co-authored-by: Marko Kovač <[email protected]> Co-authored-by: Arthur <[email protected]> * env path * rename deploy workflow, effective for any ssh-able target * rename deploy workflow, effective for any ssh-able target * fix file --------- Co-authored-by: Osnat Katz Moon <[email protected]> Co-authored-by: Patrick Delaney <[email protected]> Co-authored-by: Marko Kovač <[email protected]> Co-authored-by: Arthur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new PublicUser type from the model in the user handlers.