Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New stat/report: bodsVersion #28

Closed
kd-ods opened this issue Jun 26, 2019 · 6 comments
Closed

New stat/report: bodsVersion #28

kd-ods opened this issue Jun 26, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Jun 26, 2019

A breakdown of Statement.publicationDetails.bodsVersion. Would give reports like:

Publication details

  • 236 statements published as BODS v1.0
  • 16 statements published as BODS v0.3
@kd-ods kd-ods added the enhancement New feature or request label Jun 26, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

#27 says one file can only have statements with the same version. So this report would be simplified?

ghost pushed a commit that referenced this issue Jun 27, 2019
@jarofgreen
Report what version of the schema we checked against
9ae63f5 
#28
@kd-ods
Copy link
Collaborator Author

kd-ods commented Jun 28, 2019

Yes - hopefully, the report would have a single line!

@ghost
Copy link

ghost commented Jun 28, 2019

This is now in master, ready for release and Cove UI work.

ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 14, 2019
@jarofgreen
New stat/report: bodsVersion
9d26371 
openownership/lib-cove-bods#28
@ghost
Copy link

ghost commented Jul 14, 2019

issue28

Have put at top in new section - we might want to add more later, like check data under different versions or more info on the different versions

ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 14, 2019
@jarofgreen
New stat/report: bodsVersion
de619a9 
openownership/lib-cove-bods#28
@kd-ods
Copy link
Collaborator Author

kd-ods commented Jul 15, 2019

Looks good.

ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 16, 2019
@jarofgreen
New stat/report: bodsVersion
0b5e762 
openownership/lib-cove-bods#28
ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 16, 2019
@jarofgreen
New stat/report: bodsVersion
a54ac85 
openownership/lib-cove-bods#28
ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 16, 2019
@jarofgreen
New stat/report: bodsVersion
524a393 
openownership/lib-cove-bods#28
ghost pushed a commit to openownership/cove-bods that referenced this issue Jul 19, 2019
@jarofgreen
New stat/report: bodsVersion
b5a13a5 
openownership/lib-cove-bods#28
@ghost
Copy link

ghost commented Jul 19, 2019

This has now been merged to master in cove and is just waiting for a deploy.

Tho currently it only appears if the data is 0.2 - because 0.2 isn't officially released yet we don't want to show it too much.

@ghost ghost closed this as completed Sep 5, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kd-ods