Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: statementType should not have codelist options #382

Merged
2 commits merged into from
Nov 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2021

#375

Overview

  • What does this pull request do?

Fixes a technical issue so compiling a schema for validation is easier.

  • How can a reviewer test or examine your changes?

See new standard at https://standard.openownership.org/en/375-fix-statement-type-codelist

Try and compile schema at https://github.com/openownership/lib-cove-bods#updating-schema-files-in-data - note fix described in those instructions is now longer needed

  • Who is best placed to review it?

Have already discussed with @rhiaro

Closes issue: #375

Translations

Documentation & Release

@ghost ghost force-pushed the 375-fix-statement-type-codelist branch from 21e371e to 95e83a0 Compare November 11, 2021 13:42
rhiaro
rhiaro previously approved these changes Nov 12, 2021
docs/schema/changelog.rst Outdated Show resolved Hide resolved
Fixes changelog entry added by 95e83a0

Co-authored-by: Amy Guy <[email protected]>
@ghost ghost requested a review from rhiaro November 12, 2021 14:24
@ghost ghost merged commit 50549c6 into master Nov 12, 2021
@ghost ghost deleted the 375-fix-statement-type-codelist branch November 12, 2021 14:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants