Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sample Mode #79

Closed
ghost opened this issue Nov 9, 2021 · 6 comments
Closed

Add Sample Mode #79

ghost opened this issue Nov 9, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 9, 2021

Split out from #69

Motivation: Users who have large files won't be able to process them using the DRT. Instead they can follow some simple instructions to create a sample file locally of a smaller size and upload that instead. This won't be able to check everything, but it will be able to check a lot of things and hopefully that will still help users.

On the home page of the tool, every upload method will have a "sample data" or "full data" switch in the UI. This could be radio buttons or a select box. ("full data" by default)

In sample mode, certain tests are not run - there wouldn't be any tests that need a full file to check properly, and thus can't be checked in a sample file. Eg:

  • Person or Entity statement not used by a ownership/control statement
  • ownership/control statement refers to a person or entity that does not exist
  • ordering checks

To do this work:

The sample mode would be added as a flag to libcovebods. (off by default)

Then the tool would be updated with a switch in the UI that is passed to libcovebods.

An issue here is that currently the home page of the tool comes from libcoveweb, which is shared with other tools. It might be possible to add the functionality to the shared library, but behind a switch so that other tools don't get it. Or it might be possible to extend the library from the cove app itself.

@ghost
Copy link
Author

ghost commented Nov 10, 2021

I've had a look again and I will estimate 3 days - I haven't totally worked out how to extend libcove in a clean way, so that might throw up some surprises.

@kd-ods kd-ods assigned ghost Apr 27, 2023
@kd-ods
Copy link
Collaborator

kd-ods commented Apr 27, 2023

Work on this is at the final stages.

@kd-ods to supply @odscjames with a doc outlining UI elements to guide people's use and understanding of Sample Mode.

@kd-ods
Copy link
Collaborator

kd-ods commented Apr 28, 2023

@odscjames - how random is the sampling in Sample mode going to be? That is: if someone runs the same large dataset through COVE twice with sample mode on, will the subset of statements tested be different each time?

@ghost
Copy link
Author

ghost commented May 3, 2023

As currently written, it's not random at all - it takes the first statements it encounters.

@kd-ods
Copy link
Collaborator

kd-ods commented May 3, 2023

Thanks @odscjames. I think that's fine, but we need to get that information to users of the Tool. I've updated the UI spec with suggested edits.

ghost pushed a commit that referenced this issue Jun 16, 2023
Adds message Queue
Adds sample mode

#79
ghost pushed a commit that referenced this issue Jun 16, 2023
Adds message Queue
Adds sample mode

#79
ghost pushed a commit that referenced this issue Jun 16, 2023
Adds message Queue
Adds sample mode

#79
ghost pushed a commit that referenced this issue Jun 16, 2023
Adds message Queue
Adds sample mode

#79
ghost pushed a commit that referenced this issue Jun 16, 2023
Adds message Queue
Adds sample mode

#79
ghost pushed a commit that referenced this issue Jul 6, 2023
Adds message Queue
Adds sample mode

#79
#97
@StephenAbbott
Copy link
Member

Closing this issue following completion of work listed in #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants