Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statementID that is an object causes a 500 error #67

Closed
Bjwebb opened this issue Aug 4, 2021 · 3 comments · Fixed by #73
Closed

statementID that is an object causes a 500 error #67

Bjwebb opened this issue Aug 4, 2021 · 3 comments · Fixed by #73

Comments

@Bjwebb
Copy link
Collaborator

Bjwebb commented Aug 4, 2021

Minimal example:

[{"statementID": {}}]
@Bjwebb Bjwebb changed the title statementID that is an ojbect causes a 500 error statementID that is an object causes a 500 error Aug 4, 2021
@mpostelnicu
Copy link

i noticed the same problem while using the tool on some badly formatted sample data, we need a more verbose error, something point out to statementId being invalid type

@ghost ghost self-assigned this Sep 21, 2021
ghost pushed a commit to openownership/lib-cove-bods that referenced this issue Sep 21, 2021
@jarofgreen
bugfix: crash when statementID is not a string
6f63877 
openownership/cove-bods#67
@ghost ghost mentioned this issue Sep 21, 2021
Merged
@ghost
Copy link

ghost commented Sep 21, 2021

id_must_be_string

ghost pushed a commit to openownership/lib-cove-bods that referenced this issue Sep 21, 2021
@jarofgreen
bugfix: crash when statementID is not a string
cc387b8 
openownership/cove-bods#67
ghost pushed a commit to openownership/lib-cove-bods that referenced this issue Sep 21, 2021
@jarofgreen
bugfix: crash when statementID is not a string
2fb506d 
openownership/cove-bods#67
ghost pushed a commit that referenced this issue Sep 22, 2021
@jarofgreen
requirements: Update all requirements
5e2f97f 
v0.10.1 of libcovebods fixes #67
@ghost ghost mentioned this issue Sep 22, 2021
Merged
@ghost ghost closed this as completed in #73 Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

Deployed

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

requirements: Update all requirements openownership/cove-bods
2 participants
@Bjwebb @mpostelnicu