Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugging #328 #340

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Contributor

I don't seem to be able to debug #328 locally so I am opening this PR just to see the logs in CI when it fails

Warning

This PR is just for debugging, please don't review it

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: cfd2f4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 4, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@340

commit: cfd2f4b

@dario-piotrowicz dario-piotrowicz force-pushed the dario/328/app-router-fetch-cache-issue branch 2 times, most recently from 95fa3bc to edaca3e Compare February 4, 2025 19:10
@dario-piotrowicz
Copy link
Contributor Author

Note (to self)

This is a successful run: https://github.com/opennextjs/opennextjs-cloudflare/actions/runs/13144594920/job/36679649557?pr=340

And this is an unsuccessful one: https://github.com/opennextjs/opennextjs-cloudflare/actions/runs/13144594920/job/36680449323?pr=340

And this is the difference between the two:
https://github.com/opennextjs/opennextjs-cloudflare/actions/runs/13144594920/job/36679649557?pr=340#step:7:76
vs
https://github.com/opennextjs/opennextjs-cloudflare/actions/runs/13144594920/job/36680449323?pr=340#step:7:76

The successful one has a set call to the key (9e8843c8dca9e12409949be1a6ba721c625e4386d2458fbfe2954a3c2279b660) while the unsuccessful one has a get call

this causes for the key to be correctly set in the successful run but not to be for the unsuccessful one

so what we need to understand is why the unsuccessful run calls set instead of get, is this timing related?

@vicb
Copy link
Contributor

vicb commented Feb 5, 2025

@dario-piotrowicz maybe setting process.env.NEXT_PRIVATE_DEBUG_CACHE can help understand what's going on

@dario-piotrowicz
Copy link
Contributor Author

@dario-piotrowicz maybe setting process.env.NEXT_PRIVATE_DEBUG_CACHE can help understand what's going on

Thanks! I always forget about that one, let me try that 🤞

@dario-piotrowicz dario-piotrowicz force-pushed the dario/328/app-router-fetch-cache-issue branch from 4f0f97f to dde6ce3 Compare February 5, 2025 10:57
@dario-piotrowicz dario-piotrowicz force-pushed the dario/328/app-router-fetch-cache-issue branch from dde6ce3 to 3338a40 Compare February 5, 2025 11:14
@conico974
Copy link
Contributor

Just passing by, could be related to this opennextjs/opennextjs-aws#713
set are called inside waitUntil (because they are not awaited before sending the response)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants