-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: waitUntil
passed around via ALS
#733
Conversation
🦋 Changeset detectedLatest commit: 40fca1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It should probably be in a minor release though, a big warning in the release note about the breaking change for custom wrapper should be enough.
We'll need to update the docs as well
Thanks for the review. I'll polish the code, add a BREAKING CHANGE changeset, and prepare a doc PR before this is released. |
waitUntil
passed around via ALS
a32d5fc
to
ea04483
Compare
@conico974 added a commit to polish the code and add a changeset, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could just fix the biome linting issue and see my 2 little comments, other than that LGTM
Co-authored-by: conico974 <[email protected]>
Thanks for the review @conico974, I have addressed the comment. |
@conico974 this a POC to fix #713
I tested locally that
waitUntil
is available for middleware and the serverwaitUntil
is fixed when there is a nested request inside a long running requestThe handler API is changed so this is a breaking change.
What do you think?