Fix bug in make_nifti method to handle Path objects correctly #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a bug fix in the
pypet2bids/ecat.py
file and I added myself to thecontributors.md
file.I modified the
make_nifti
method to correctly check if the output file name ends with "nii.gz" usingpathlib.Path(output).name
instead of checking the entire path string. Sincepathlib.Path
objects are not iterable, the"nii.gz" not in output
check would otherwise throw a TypeError, ifoutput
is not a string but aPath
object. Since providing the nifti_file as a pathlib.Path object does not throw errors in other places of the code, at least when running.convert()
, I considered this a bug.📚 Documentation preview 📚: https://pet2bids--333.org.readthedocs.build/en/333/