(feat) O3-4211: Reuse patient banner components across search #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -102 kB (-1.6%) Total Size: 6.27 MB
ℹ️ View Unchanged
|
denniskigen
force-pushed
the
feat/O3-4211
branch
3 times, most recently
from
1e6f7fa to
7f453ee
Compare
NethmiRodrigo
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
LGTM! Thanks @denniskigen!
There's this extremely small styling thing that we'll probably need to fix later on where the actions button isn't taking up the entire height similar to how the start visit button or the show more button does:
Yeah, I fixed this issue in openmrs/openmrs-esm-core#1284. The issue here is that bumping the core tooling requires changes to the tests that use the |
Replaces several custom patient banner implementations across patient search interfaces with standardized components from the styleguide. This change: - Removes duplicate patient banner logic and styling - Improves consistency across patient search interfaces - Reduces overall code duplication - Simplifies mapping patient data from REST to FHIR - Reduces maintenance overhead by leveraging shared components - Cleans up redundant CSS rules and improves styling consistency Testing: - Temporarily disabled tests with assertions related to elements in the patient banner. - Added TODOs to restore tests once we improve the stub implementation of the styleguide components (or get rid of them altogether in favor of the actual implementations).
denniskigen
force-pushed
the
feat/O3-4211
branch
from
44ae2d4 to
d665f21
Compare
|
Fixed:
|
ibacher
approved these changes
Feb 18, 2025
| interface IdentifierTagProps { | ||
| identifier: Identifier; | ||
| } | ||
| const getGender = (gender: string) => { |
There was a problem hiding this comment.
Does it make sense to refactor this into it's own shared file?
There was a problem hiding this comment.
Yeah. Probably makes even more sense to centralize all of the REST to FHIR mapping logic into a reusable hook in a utils file or something similar. I can ticket that and add it to the epic.
There was a problem hiding this comment.
I've filed https://openmrs.atlassian.net/browse/O3-4464
|
I've also filed https://openmrs.atlassian.net/browse/O3-4465 to fix the test stubs. |
|
Thanks @denniskigen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Replaces several custom patient banner implementations across patient search interfaces with standardized components from the styleguide. This change:
Testing:
Screenshots
Basic search on desktop
Advanced search on desktop
Service queues search on desktop
Service queues search on desktop with action buttons clicked
Appointments search on desktop
Appointments search overlay on tablet
Related Issue
https://openmrs.atlassian.net/issues/O3-4211
Other