-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3725: Show complete error in snackbar when creating/editing a form #1462
Conversation
Size Change: +46 B (0%) Total Size: 7.36 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Not 100% sure, but I think server-side error messages are usually formatted server-side.
908baf7
to
5dcc5b5
Compare
Yup, @chibongho. Thanks for getting this started, @NethmiRodrigo. FYI @dkayiwa. This is what I had in mind with my "better error messages from the backend" spiel. Also related - openmrs/openmrs-esm-core#1230. |
The grammar in the error message here could be improved for clarity. @chibongho, should we go ahead and fix it? |
@denniskigen I've already fixed it and it got merged in - openmrs/openmrs-module-bedmanagement#78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NethmiRodrigo!
Requirements
Summary
This PR updates the error message shown in the snackbar for when editing/creating a bed. The message received from the backend might need some formatting, or I don't know if this is something we need to format on the frontend.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-3725
Other