Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make useConfig also work for extension config #44

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Make useConfig also work for extension config #44

merged 1 commit into from
Nov 29, 2020

Conversation

brandones
Copy link
Collaborator

No description provided.

brandones
brandones commented Nov 29, 2020
View reviewed changes
packages/esm-react-utils/src/useConfig.test.tsx
@@ -91,6 +93,176 @@ describe(`useConfig`, () => {
});
});

describe(`useConfig in an extension`, () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests copy-pasted from useExtensionConfig.test.tsx

jonathandick
jonathandick approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving all logic into one hook. I think this is will be easier to understand.

@brandones brandones merged commit 7ec8b73 into master Nov 29, 2020
@brandones
Copy link
Collaborator Author

Yeah, thanks for the good idea!

@FlorianRappl FlorianRappl deleted the consolidate-use-conf branch November 29, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathandick jonathandick jonathandick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandones @jonathandick