-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Miscellaneous DevTools panel fixes #1268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies the following fixes to the DevTools panel that improve accessibility and consistency: - Replaces the `div`-based DevTools launch trigger button with a Carbon `IconButton` for improved accessibility. - Replaces the DevTools popup close button with a Carbon `IconButton`. - Improves WCAG compliance by fixing contrast ratios of the DevTools panel trigger button and the DevTools panel close button. Also fixes the contrast ratio of overriden module list items to a red hue with a contrast ratio greater than 5:1. - Removes CSS that provides spacing between the elements in the "Add Module" modal and replaces it with a Carbon `Stack` component for more consistent spacing. - Adds unique keys to the list items in the ImportMap list, fixing a React warning about duplicate keys.
Size Change: -99.3 kB (-1.58%) Total Size: 6.19 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR applies the following fixes to the DevTools panel that improve accessibility and consistency:
<div>
-based DevTools launch trigger button with a CarbonIconButton
for improved accessibility.IconButton
.Stack
component for more consistent spacing.Screenshots
DevTools enabled
DevTools popup
Add module modal
Related Issue
Other