-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Gender icons not showing in non-English locales #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where gender icons would not show in non-English locales. With this fix, gender icons will now show in all locales.
ibacher
approved these changes
Dec 16, 2024
Size Change: -87.8 kB (-1.4%) Total Size: 6.17 MB
ℹ️ View Unchanged
|
Don't merge yet; adding a test shortly |
denniskigen
added a commit
that referenced
this pull request
Dec 16, 2024
Cuts a patch release of Core, v6.0.1, with [a bug fix](#1241) for gender icons in the Patient banner not showing in non-English locales. This also crucially updates peer dependencies to point to the versions of `@openmrs` scoped packages that match the 6.x range.
denniskigen
added a commit
that referenced
this pull request
Dec 17, 2024
Cuts a patch release of Core, v6.0.1, with [a bug fix](#1241) for gender icons in the Patient banner not showing in non-English locales. This also crucially updates peer dependencies to point to the versions of `@openmrs` scoped packages that match the 6.x range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Fixes an issue where gender icons would not show in non-English locales. With this fix, gender icons will now show in all locales.
Screenshots
Before
After
Related Issue
Other