Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-4215: Enable Environment Specification for Shell Builds #1211

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Nov 21, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR introduces the ability to specify the build environment using the --env argument. By default, the environment is set to production if no argument is provided.

Motivation:
The esm-tutorials app requires tutorials to be enabled by default in the development environment while remaining disabled (or enabled by config) in production. This change makes it easier to handle such environment-specific configurations.

Related Issue

https://issues.openmrs.org/browse/O3-4215

@jayasanka-sack jayasanka-sack changed the title Enable Environment Specification for Shell Builds (feat) O3-4215: Enable Environment Specification for Shell Builds Nov 21, 2024
@jayasanka-sack jayasanka-sack marked this pull request as ready for review November 21, 2024 08:50
@jayasanka-sack jayasanka-sack requested review from ibacher, denniskigen and vasharma05 and removed request for denniskigen and vasharma05 November 21, 2024 08:50
@ibacher
Copy link
Member

ibacher commented Nov 22, 2024

One small feature request here: could we also enable setting the environment via an env key in the build config JSON? This is more useful long-term, I think.

@jayasanka-sack
Copy link
Member Author

@ibacher done! :)

@ibacher ibacher merged commit 1d11a98 into openmrs:main Nov 27, 2024
14 checks passed
@jayasanka-sack jayasanka-sack deleted the O3-4215 branch November 28, 2024 04:22
@denniskigen denniskigen mentioned this pull request Dec 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants