Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Ensure Confirm button in login location picker takes full width #1106

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Aug 2, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

The Confirm button on the Change Location page was not taking the full width. This PR fix it by adjusting the CSS to ensure the Confirm button spans the full width of its container.

Screenshots

Before:
image

After:
image

Related Issue

Other

@jayasanka-sack jayasanka-sack changed the title (fix) Ensure Confirm button in location picker takes full width (fix) Ensure Confirm button in login location picker takes full width Aug 2, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jayasanka-sack!

@denniskigen denniskigen merged commit e9d98e4 into openmrs:main Aug 2, 2024
11 checks passed
@jayasanka-sack jayasanka-sack deleted the feat/login/confirm_btn branch August 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants