(feat): Enhancements to the OpenmrsDatePicker #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On hindsight, instead of making separate styles for the asterisk only, there's probably a carbon className I could use. |
NethmiRodrigo
changed the title
|
Size Change: -364 kB (-8.97%) ✅ Total Size: 3.7 MB
ℹ️ View Unchanged
|
NethmiRodrigo
commented
Jul 1, 2024
packages/framework/esm-styleguide/src/datepicker/datepicker.module.scss
Outdated
Show resolved
Hide resolved
ibacher
reviewed
Jul 1, 2024
Comment on lines
297
to
298
| color: #da1e28 !important; | ||
| margin-left: 0.25rem; |
There was a problem hiding this comment.
I think you could also get the color right by applying the .cds--form-requirement class.
Suggested change
| color: #da1e28 !important; | |
| margin-left: 0.25rem; | |
| color: theme.$text-error !important; | |
| margin-left: spacing.$spacing-02; |
There was a problem hiding this comment.
I tried cds--form-requirement as the className, but it didn't work. I tried looking in Carbon's playground but I couldn't find any required styling for the inputs, so I updated the styles, as suggested.
There was a problem hiding this comment.
Just saw that by default cds--form-requirement has a display: none that gets overriden by some selectors based on if the input is disabled and so on.
NethmiRodrigo
changed the title
ibacher
reviewed
Jul 2, 2024
packages/framework/esm-styleguide/src/datepicker/datepicker.module.scss
Outdated
Show resolved
Hide resolved
|
Any reason this is still marked as draft? |
@ibacher Yeah I want to fix the |
|
@ibacher Wherever we've used Carbon inputs in form engine, we have passed in a custom component for |
Yes, we should keep things consistent, I think. |
NethmiRodrigo
changed the title
3 tasks
ibacher
force-pushed
the
feat/enhance-openmrs-date-picker
branch
from
da6521a to
c296e16
Compare
ibacher
approved these changes
Jul 5, 2024
samuelmale
approved these changes
Jul 5, 2024
|
That is the first time I've seen Turbo cause a build failure... |
Twiineenock
pushed a commit
to Twiineenock/openmrs-esm-core
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Ian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Screenshots
This PR adds styling enhancements to the Date Picker.
<Label>component with the classNamecds-label.After fix:
invalidText. Renders the text passed in to the propinvalidTextif the conditionisInvalidis true, with the carbon styling for an error message applied.invalidtoisInvalid.Related Issue
Other