-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jurisdictions API spec (read-only endpoints) #593
Add Jurisdictions API spec (read-only endpoints) #593
Conversation
Feedback below from the working group meeting. See full notes here. Brian Ng presentation.
@brianngca can you make sure to sign the CLA for your contribution? |
@brianngca thanks for signing the CLA. @brianngca and @janedotx If you can incorporate the feedback from the WG meeting in the comment above, I will notify the members to review and comment for the 1.1.0 release. It would need to be reviewed in one of the next 2 WG calls as a final community check for the release. |
@schnuerle Thanks for writing up the summary of the WG meeting and feedback. I'll start incorporating the feedback into the text with @janedotx |
@janedotx I made some comments to help resolve some formatting, TOC, and beta language issues. All minor. If you can edit the PR and check the recommended "allow edits from maintainers" checkbox I could make these for you. |
This commit has a lot of what looks like auto-formatting changes going on to the main MDS readme. Some are ok like removing spaces, but others are changing "-" to "*" in lists. While this is ok, I don't think these changes need to be made in the Jurisdiction PR. Could you revert changes like this? |
I can't find the "allow edits from maintainers" checkbox on the lacuna-tech fork. |
So that link just goes to this PR, and looking at the diff, the only addition to the general README is the addition of the Jurisdictions section. Commit |
Yes that's ok, didn't see the cleanup later, thank you for clarifying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for release candidate.
Explain pull request
See #491 for the discussion and motivations behind this pull request.
Is this a breaking change
Impacted Spec
Which spec(s) will this pull request impact?
geography
Additional context
#491