Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #170

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Fix warnings #170

merged 6 commits into from
Aug 25, 2022

Conversation

PGijsbers
Copy link
Member

Minor changes to avoid warnings, or explicitly ignore them in for pytest with motivation.

The scipy warning is caused by scikit-learn internal usage of scipy.
See scikit-learn/scikit-learn#23633
The previous statement was ambiguous as  the `not in` operation could also
interpreted to be used in element-wise fashion.
This allows you to reconstruct an individual if additional hyperparameters
have been added to the search space.
@PGijsbers PGijsbers added the CI label Aug 25, 2022
@github-actions
Copy link

github-actions bot commented Aug 25, 2022

Thank you for the pull request! 🙏
If CI reports any errors please address them.
If you believe the errors are unrelated to your PR, please state why.
This will make it easier for the maintainers to assess your PR :)

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #170 (db74a53) into master (556d601) will increase coverage by 2.54%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   65.72%   68.26%   +2.54%     
==========================================
  Files          45       45              
  Lines        2188     2187       -1     
==========================================
+ Hits         1438     1493      +55     
+ Misses        750      694      -56     
Flag Coverage Δ
unit-tests 68.26% <77.77%> (+2.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gama/GamaClassifier.py 54.34% <0.00%> (ø)
gama/configuration/classification.py 100.00% <ø> (ø)
gama/configuration/regression.py 100.00% <ø> (ø)
gama/configuration/testconfiguration.py 100.00% <ø> (ø)
gama/postprocessing/ensemble.py 43.34% <66.66%> (+21.21%) ⬆️
gama/genetic_programming/components/individual.py 89.85% <100.00%> (ø)
...a/genetic_programming/components/primitive_node.py 95.83% <100.00%> (+2.08%) ⬆️
gama/logging/GamaReport.py 91.35% <100.00%> (+1.35%) ⬆️
gama/utilities/evaluation_library.py 82.53% <0.00%> (+0.79%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@PGijsbers PGijsbers merged commit d2c297a into master Aug 25, 2022
@PGijsbers PGijsbers deleted the fix_warnings branch August 25, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant