Migrate to MapLibre GL JS #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks for contributing. We will update /languages/ later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Replaces MapBox GL references with MapLibre GJ. Changed demo and viewers page.
Could use some feedback regarding following pages:
docs/style/mapbox-gl-style-spec.md
I think the style spec is still MapBox GL, added a note regarding the Javascript library to clarify MapBox style spec vs MapLibre JS.
/inspect.md
This page uses a copy of the Mapbox library
/inspect/mapbox-gl.jsand some custom inspect JS file. Didn't dare to touch this. Can't seem to find a reference towards this page though...languages pages (ie. https://openmaptiles.org/languages/az/)
These pages load a Javascript file
https://cdn.klokantech.com/openmaptiles-language/v1.0/openmaptiles-language.jswhich refers a globally definedmapboxgl. This returns an error when I migrate to MapLibre GL and it breaks the multilingual demo. This Javascript file is not in this project, so not sure how to handle this...