Clearer management of files when assigning typesetting

[joemull]

This tackles a set of related issues with file management during typesetting assignments, especially in subsequent rounds of typesetting involving proofing files and galley correction.

• Closes Improve visibility of proofed files when assigning typesetting corrections #166
• Closes On assignment creation screen, list Typeset Files in the "2. Select Files [for typesetting]" field #194
• Closes Allow editors to select what proofing comments/files are shared with the typesetters #152
• Closes Correction Files #154
• Closes Add an upload button for further proofs on the typesetting assignment page #140
• Closes Author Uploaded Proofing Files not available to Typesetters #138
• Closes Logic bug when uploading a file for typesetting janeway#4314

Regarding #152, this PR does not allow editors to individually select proofreaders' comments, but it does allow them to individually select proofing files separately from comments, and upload their own proofing files. If they want to collate the comments together, they can do this more easily given the summary/details display of proofing comments.

Dependencies:

• Improve usability of file types janeway#4327
• Buttons and labels for complicated forms janeway#4328

Editor's main view of typesetting files

Editor assigns a typesetter

Typesetter views the assignment

[ajrbyers]

Thanks for this @joemull I think this will help editors out a lot with this step in the process.

• I've added two review comments
• I do have a concern around not presenting the typesetters, automatically, with figure files. Do you think editors will be okay with selecting them? I think journals like CG will consider this a step backwards as they often have large numbers of images that will need to be selected.
• For articles in typesetting we will need a data migration that will add the figures to the list of files for the typesetter otherwise they will lose access to them.

Let me know what you think about the above.

[joemull]

I do have a concern around not presenting the typesetters, automatically, with figure files. Do you think editors will be okay with selecting them? I think journals like CG will consider this a step backwards as they often have large numbers of images that will need to be selected.

I think we got into trouble with the usability of this interface by automatically controlling the visibility of things, so what if we make a button with which editors can select all figure files, if they want to? I think I can expand the select_all widget to support looking for value in a data- attribute, and we could use the result of file_type there.

For articles in typesetting we will need a data migration that will add the figures to the list of files for the typesetter otherwise they will lose access to them.

I can write a migration for this.

[joemull]

Or we could add a setting that controls whether they are pre-selected.

Or if we think most people will want this, we could just preselect them always, without a setting. A few other things are now preselected, so this would not be unique behavior.

Thoughts @ajrbyers ?

[joemull]

@ajrbyers I've gone ahead and pre-checked data and figure files.

[ajrbyers]

Generally this is really good.

1. When assigning a correction request the editor is presented with the option to select Galley files twice. They Typesetter will have access to the Galley regardless of whether the editor selects the file here.

2. When logged in as a Typesetter and undertaking a correction task I was able to see the same Galley listed twice.

3. The article metadata has been moved to the foot of the Typesetter page. Would it be worth adding some sort of signpost? It could easily be missed.

[joemull]

Thanks @ajrbyers.

1. When assigning a correction request the editor is presented with the option to select Galley files twice.

One part of the form asks "Which files should be used?" and the other asks "Which galleys need to be corrected?". The two are different things and it is important to be literal and clear in these interfaces, according to the user reports. The selected files control different lists on the typesetter's end, with different explanations (see below).

I prevent errors with the confirmable form:

https://github.com/BirkbeckCTP/typesetting/blob/07115db9480f3919d0bef0ec9ad614be38fbcc2e/forms.py#L92-L105

They Typesetter will have access to the Galley regardless of whether the editor selects the file here.

That's how it used to work, but I changed it because that was one of the sources of confusion. The typesetter sees this text above the first list of files:

"The following files have been selected for use or reference when generating the typeset articles."

For "have been selected" to be true, it is important that all the files, and only the files, selected by the editor appear here. Otherwise the interface can contradict the editors' instructions, which is a source of confusion that users reported.

Granted, it is true that the galley files uploaded by the typesetter will always appear in a separate list. The text above that list says:

"Any galleys (typeset files) that were selected by the editor for correction, or that you originally uploaded, will appear here."

This list needs to stay separate so that the editors' selection is a meaningful piece of communication between editor and typesetter.

2. When logged in as a Typesetter and undertaking a correction task I was able to see the same Galley listed twice.

Thanks for catching that. I'll fix it.

3. The article metadata has been moved to the foot of the Typesetter page. Would it be worth adding some sort of signpost? It could easily be missed.

I've added a skip link. Doesn't look fantastic but it will do the trick for now:

[ajrbyers]

🥇