Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the display of date_submitted and date_accepted on OLH and Material themes #4480

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fixes the display of date_submitted and date_accepted on OLH and Material themes #4480

merged 2 commits into from
Nov 5, 2024

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Nov 4, 2024

Closes #4479

@ajrbyers ajrbyers changed the base branch from master to r-v1.7.x November 4, 2024 12:30
@ajrbyers ajrbyers added this to the v1.7.x milestone Nov 4, 2024
@ajrbyers ajrbyers requested a review from mauromsl November 5, 2024 09:54
mauromsl
mauromsl requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the cache

src/submission/models.py Outdated Show resolved Hide resolved
@mauromsl mauromsl assigned ajrbyers and unassigned mauromsl Nov 5, 2024
@ajrbyers ajrbyers assigned mauromsl and unassigned ajrbyers Nov 5, 2024
@ajrbyers ajrbyers requested a review from mauromsl November 5, 2024 10:28
@mauromsl mauromsl requested a review from StephDriver November 5, 2024 11:28
@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Nov 5, 2024
StephDriver
StephDriver approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@StephDriver StephDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with accepted, and with submitted setting too, works.

@StephDriver StephDriver merged commit 57cb535 into r-v1.7.x Nov 5, 2024
@StephDriver StephDriver deleted the b-4479-bugfix branch November 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephDriver StephDriver StephDriver approved these changes

@mauromsl mauromsl mauromsl approved these changes

Assignees

@StephDriver StephDriver

Labels
priority-urgent
Projects
None yet
Milestone
v1.7.x
Development

Successfully merging this pull request may close these issues.

Date Submitted and Date Accepted are not displaying
3 participants
@ajrbyers @StephDriver @mauromsl