Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where a server error was raised when downloading a PDF for an invalid article identifier #4344

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fixed an issue where a server error was raised when downloading a PDF for an invalid article identifier #4344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/journal/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2646,7 +2646,7 @@ def serve_article_pdf(request, identifier_type, identifier):
identifier,
)

if not article_object and not article_object.is_published:
if not article_object or not article_object.is_published:
raise Http404

pdf = article_object.pdfs.first()
Expand Down