-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a skip to content link to all themes that is tab navigable #4332
Conversation
Andy, I'm not too keen on this. Pretty much everywhere I've seen "skip to content" implemented, it doesn't appear over the top of existing content. I've seen some places do it by having strategically positioned whitespace, others by dynamically scrolling the whole page down or sideways to make space for new accessible menu items like this. Here's an example of the functionality on the Access to Work site from .gov.uk - i.e. aimed at disabled users. (tabs are highlighting in yellow) skip_to_content.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment on above - I don't think having this over the top of other content is an accessible implementation. It won't just be people who can't see the page who use this functionality. It shouldn't be obscuring other content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the behaviour here is quite right yet.
When I tested this, while the "skip to content" link did move the page (✅ ) if I then tab again, I'm back at the top at the next item after skip to content. So basically having had the skip, I can't continue from that point ( ❌ ). After skipping the next tab item should be the next one after the start of hte main content, not taking me back to the top of the page.
I've tested this on Chrome with a press site and journal site - finding the same behaviour on both.
Which theme did you test this with? |
OLH. I've just tried Clean and Material - and those are both fine. So I think just an OLH issue? |
Yeah I just tested it there too. I think its intercepting the click so the anchor link isn't set and the focus doesn't move. |
I'll leave it with you then - I think that's the only problem remaining - from what I can see the rest of the requirements are there: ✅ link is the first focusable control on the Web page. from WCAG G1 |
@StephDriver I've updated OLH's JS to stop it intercepting the anchor hash being added to the URL bar. All looks okay now. To test this locally you will need to run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a comment on the behaviour on landing pages, which I think should be addressed separately. Otherwise I'm happy to approve this.
<main>