Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository submission now has a review page before submission is complete #4330

Closed
wants to merge 30 commits into from
Closed

Repository submission now has a review page before submission is complete #4330

wants to merge 30 commits into from

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Jul 19, 2024 •
edited
Loading

  • Moves the submission event call to repository_review.
  • Displays metadata, author and file data on the review page for authors to check
  • Includes a new setting for repository specific text
  • Includes links back to previous workflow steps
  • Updates the breadcrumbs
  • Includes a new key/value pair layout element
  • Closes Summary page at end of preprint submission process #3478

This PR adds a template for displaying title or key and value pairs. This may be something we want to consider including in our component library with options for displaying titles in different places for emphasis. This simply includes the key/title above the value.

Metadata and complete sections:
Screenshot 2024-07-19 at 15 09 50

Authors, files and supp files sections:
Screenshot 2024-07-19 at 16 00 18

@ajrbyers ajrbyers requested a review from joemull July 22, 2024 09:43
joemull
joemull requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! A few small comments inline.

@joemull joemull assigned ajrbyers and unassigned joemull Jul 23, 2024
@joemull
Copy link
Member

joemull commented Jul 23, 2024

Oh, one last comment that I did not include on the review: can "Complete Step 3 of 3" be "Complete Step 3 of 3 and Review" or something less verbose, so that the author knows what will happen when they click that button, and isn't expecting the whole thing to submit?

@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Aug 7, 2024
@ajrbyers ajrbyers requested a review from joemull August 7, 2024 13:32
@ajrbyers
Copy link
Member Author

ajrbyers commented Aug 7, 2024

Thanks @joemull. I've added updates here and requested a re-review.

@joemull joemull requested a review from StephDriver August 8, 2024 11:23
@joemull joemull removed the request for review from StephDriver August 8, 2024 11:26
@joemull joemull assigned ajrbyers and unassigned joemull Aug 8, 2024
ajrbyers and others added 14 commits August 13, 2024 09:25
@ajrbyers
#3478 adds a proper review page for repo subs.
3890a0f
@ajrbyers
#3478 updated HTML in repo/submit/review.html
ee40733
@ajrbyers
#3478 update link tag and add sr-only text.
1f03245
@ajrbyers
#3478 swap key color for dimgray hex code. Snrk.
7a76694
@ajrbyers
#3478 simplify the template logic for repository submission breadcrumb.
3fa5733
@ajrbyers
#3478 addreses inline review comments.
ba34839
@ajrbyers
#3478 use a definition list to make content semantic
1c683a5
@ajrbyers
#3478 removes stray closing paragraph tag.
35d8340
@joemull @ajrbyers
Add related name for copyeditor files BirkbeckCTP/typesteting#166
494d42f
@joemull @ajrbyers
Add Galley.detail to display more info openlibhums/typesetting#166
34bffea
@joemull @ajrbyers
Add a template tag for a uuid4 openlibhums/typesetting#166
7842f90
@joemull @ajrbyers
Set of buttons for easy input of date fields openlibhums/typesetting#166
d0af16e
@joemull @ajrbyers
Upgrade check_all widget to component #166
8fe20e7
@joemull @ajrbyers
Allow multiple datatables on one page openlibhums/typesetting#166
edf717d
joemull and others added 16 commits August 13, 2024 09:25
@joemull @ajrbyers
Simplify Galley.detail method to avoid timezone issue #166
f940957
@joemull @ajrbyers
Do not shorten uuid4
94c15a3
@joemull @ajrbyers
Generalize and document offset_date
470582a
@ajrbyers
#4342 add revisions to logic check on revision dashboard.
ca66a1c
@ajrbyers
Rebase.
2f7bd84
@StephDriver @ajrbyers
3911 updated article template Download and Checksum to test for galle…
7eb9b5d 
…ys empty

rebased
@StephDriver @ajrbyers
3911 autogenerated list of table of contents removed if it has no con…
4fff209 
…tents
@StephDriver @ajrbyers
3911 minor debugging changes
5ed264d
@StephDriver @ajrbyers
3911 update consistency of approach across all themes
8ccd6c4
@StephDriver @ajrbyers
3911 debugging clean theme changes following testing
581e5a4
@StephDriver @ajrbyers
3911 more debugging clean theme changes following testing
e612f05
@StephDriver @ajrbyers
3911 Material and Clean hide TOC debugging
4c13005
@StephDriver @ajrbyers
3911 OLH fix not avaliable until published logic error introduced ear…
33a2c03 
…lier
@StephDriver @ajrbyers
3911 material update to same hide TOC structure
0fd7cb0
@StephDriver @ajrbyers
3911 clean update to ensure proofing download note appears when there…
3c0d46c 
… are galleys
@ajrbyers
Updates clean to use frozen authors for citation modals.
65a7725
@ajrbyers ajrbyers force-pushed the 3478-submission_summary branch from 39923ce to 65a7725 Compare August 13, 2024 08:26
@ajrbyers
Copy link
Member Author

Closing this in favour of a clean branch: #4357

@ajrbyers ajrbyers closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemull joemull joemull requested changes

Assignees

@ajrbyers ajrbyers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary page at end of preprint submission process
3 participants
@ajrbyers @joemull @StephDriver