Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4256 updates views with journal filters. #4257

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Jun 6, 2024

Note: Two other approaches were discussed and should be considered for future:

  1. Switching these views to a new decorator that includes these checks
  2. Switching these views to CBVs that inherit from a parent that has these checks

@ajrbyers ajrbyers requested a review from mauromsl June 6, 2024 11:44
@mauromsl mauromsl added this to the v1.5.6 milestone Jun 6, 2024
@mauromsl mauromsl requested a review from joemull June 6, 2024 12:32
@mauromsl mauromsl removed their assignment Jun 6, 2024
@joemull joemull merged commit 6fc4b2b into release_1_5_x Jun 6, 2024
1 check failed
@joemull joemull deleted the 4256-hotfix branch June 6, 2024 12:55
@joemull joemull linked an issue Jun 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some views are visible across journal boundaries
3 participants