Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3936 add alt text to social media buttons #4178

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

StephDriver
Copy link
Contributor

  • Share icons now have aria-labels on OLH and Material themes (no share icons found on Clean).
  • Dyslexia, text size, print icons now have aria-labels on OLH (not found on Material or Clean).
  • How to Cite icon now has Aria label and is no longer invisible to screen reader or keyboard navigation (tested with Mac Voice-over). The dropdown inside it for different citation format also now works with tab and screen reader.
  • The options hamburger button for narrow windows how has an aria label for 'options'.

All tested with Mac Voice Over. Related bugs noticed (such as difference in order between visual and tab) which will feed into the current A11y audit, but as for what was reported in this issue, that has now been fixed.

Closes #3936

Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but as they're on the front of house we should mark the aria-labels as translatable!

@ajrbyers ajrbyers assigned StephDriver and unassigned ajrbyers Jun 26, 2024
@StephDriver StephDriver requested a review from ajrbyers June 26, 2024 15:29
@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Jun 26, 2024
@ajrbyers ajrbyers requested a review from joemull July 11, 2024 12:45
@ajrbyers ajrbyers removed their assignment Jul 11, 2024
@joemull joemull merged commit 02b52ee into master Jul 15, 2024
1 check failed
@joemull joemull deleted the 3936-add_alt_text_to_social_media_buttons branch July 15, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu item missing a text alternative
3 participants