Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Notify Author email field with TinyMCE #4107

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Apr 18, 2024

This uses a bare-bones Django form to put TinyMCE into an arbitrary template as a hotfix for #4089. It does not fully address #4089 because we would like to refactor it a bit more in a later minor version of Janeway--see #4094.

Screenshot from 2024-04-22 16-52-57

@joemull joemull requested a review from mauromsl April 18, 2024 11:54
@ajrbyers ajrbyers assigned ajrbyers and mauromsl and unassigned joemull and ajrbyers Apr 22, 2024
@mauromsl mauromsl assigned joemull and unassigned mauromsl Apr 22, 2024
@joemull joemull requested a review from mauromsl April 22, 2024 16:02
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that does the trick for me

@mauromsl mauromsl requested a review from ajrbyers April 22, 2024 16:08
@mauromsl mauromsl assigned ajrbyers and unassigned joemull Apr 22, 2024
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is an import that may not belong on this branch though.

@mauromsl mauromsl merged commit adc95e5 into b_1_5_2 Apr 22, 2024
1 check was pending
@mauromsl mauromsl deleted the 4089-notify-author-hotfix branch April 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants