Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSL support for the JATS verse-line/@style attribute #4078

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

tbelc
Copy link
Contributor

@tbelc tbelc commented Apr 4, 2024

Request to enhance the verse-line element template to support the style attribute. If the style attribute is present, then its value is passed to the resulting HTML via the inclusion of a span element. If the style attribute is not present, then behavior is not changed.

Currently, it appears the default behavior is inline and monospaced. This request allows for the ability to control the styling of the content within the verse-line element.

For example, the following JATS markup:

<disp-quote content-type="epig">
<verse-group>
<verse-line style="display:block;font-style:italic;font-family:serif">"Make no little plans. They have no power to stir men’s blood."</verse-line>
<verse-line style="display:block;font-style:italic;font-family:serif">Daniel Burnham, as quoted in <italic>Devil in the White City</italic></verse-line>
</verse-group>
</disp-quote>

currently produces the following HTML display:

verse_line_default

This request will allow for the following HTML display:

verse_line_request

@Bbkctp
Copy link
Contributor

Bbkctp commented Apr 4, 2024

Can one of the admins verify this patch?

@mauromsl
Copy link
Member

mauromsl commented Apr 5, 2024

Thanks @tbelc!

@mauromsl mauromsl requested a review from ajrbyers April 5, 2024 08:35
@ajrbyers ajrbyers removed their assignment Apr 5, 2024
@ajrbyers ajrbyers merged commit d14641c into openlibhums:master Apr 5, 2024
@ajrbyers
Copy link
Member

ajrbyers commented Apr 5, 2024

Thanks @tbelc! Rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants