Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editors have more control over editorial team display #4068

Merged
merged 19 commits into from
Apr 16, 2024
Merged

Editors have more control over editorial team display #4068

merged 19 commits into from
Apr 16, 2024

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Mar 28, 2024 •
edited
Loading

Closes #2433
Closes #3146
Closes #908

  • Adds new default editorial team image to journals
  • Updates display to use in order: User Profile Image > Journal Default > Janeway Default
  • Moves control of display images to the EditorialGroup model and sets this based on the old setting, journals should not experience a change in their ET display
  • Moves editorial team settings onto the editorial team manager page
  • Adds two new settings allowing control of the name for the ET page and whether group names display

An example showing a Journal level default EG image and a group that has been set not to display amongst others that do.

image

@ajrbyers ajrbyers requested a review from mauromsl March 28, 2024 12:52
mauromsl
mauromsl requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments inline, but the main question is if we want to use the new configurable image everywhere where the icons/users.png image is currently in use (and then name the setting appropriately)

src/themes/OLH/templates/core/nav.html Show resolved Hide resolved
docs/source/manager/journal/index.rst Outdated Show resolved Hide resolved
@mauromsl mauromsl changed the title #2433 #3146 Updates Janeway to allow a journal level default editorial team image and moves control of displaying images to editorial team groups Added support for journal level default editorial team image and moved control of displaying images to editorial team groups Apr 2, 2024
@ajrbyers ajrbyers requested a review from mauromsl April 2, 2024 15:20
mauromsl
mauromsl approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just a small title change on the docs from me

docs/source/manager/journal/index.rst Outdated Show resolved Hide resolved
@mauromsl mauromsl requested a review from joemull April 2, 2024 16:27
joemull
joemull requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great! I picked up a few usability things and then I'll be happy to approve this.

docs/source/manager/journal/index.rst Outdated Show resolved Hide resolved
src/templates/common/elements/profile_image.html Outdated Show resolved Hide resolved
src/themes/OLH/templates/journal/editorial_team.html Outdated Show resolved Hide resolved
src/themes/OLH/templates/journal/editorial_team.html Show resolved Hide resolved
@joemull joemull changed the title Added support for journal level default editorial team image and moved control of displaying images to editorial team groups Editors have more control over editorial team display Apr 4, 2024
ajrbyers added 19 commits April 15, 2024 16:30
@ajrbyers
#2433 #3146 update settings and models.
6caf3ff
@ajrbyers
#2433 #3146 add display_profile_images to admin
fb09a40
@ajrbyers
#2433 #3146 update forms and settings tempaltes
8e3df23
@ajrbyers
#2433 #3146 remove enable_editorial_images from group_styling template
25be714
@ajrbyers
#2433 #3146 move <img> output to common template and update theme tem…
c73a04a 
…plates to use it.

Order of pref: User Profile Image > Journal Default > Janeway Default
@ajrbyers
#2433 #3146 Add new image to image docs.
29b2569
@ajrbyers
Merge journal_defaults.json
59d478e
@ajrbyers
#908 update the editorial team pages to work with new settings
b89ba96
@ajrbyers
#908 complete previous commit
d476538
@ajrbyers
#908 update journal nav to use new editorial group page name setting
3521cd3
@ajrbyers
#908 use the editorial group page name setting on the CMS nav element.
fe3769b
@ajrbyers
Sets FR, DE, NL and CY values for editorial_group_page_name setting.
f79dbdf
@ajrbyers
Update model to reflect new usage of this file (default_profile_image)
352d534
@ajrbyers
Update templates with new usage.
ec0c6b6
@ajrbyers
Tweaked docs.
30a18c5
@ajrbyers
Fixes comma splice.
b2eb676
@ajrbyers
Changes default alt text for profile image.
0073e86
@ajrbyers
Group names are now H2 in the OLH theme
79c1de8
@ajrbyers
Editing editorial team settings will now clear Janeway's cache ensuri…
d719990 
…ng settings changes are visible immediately
@ajrbyers ajrbyers force-pushed the 2433-3146-editorial_team_images branch from acd034d to d719990 Compare April 15, 2024 15:33
@ajrbyers ajrbyers requested a review from joemull April 15, 2024 15:44
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Apr 15, 2024
@joemull joemull merged commit a165366 into master Apr 16, 2024
1 check failed
@joemull joemull deleted the 2433-3146-editorial_team_images branch April 16, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

@joemull joemull joemull approved these changes

Assignees

@joemull joemull

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ajrbyers @mauromsl @joemull @StephDriver