use timezone when recording date_published at preprint acceptance #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ajrbyers
requested review from
ajrbyers and
mauromsl
and removed request for
ajrbyers
ajrbyers
reviewed
Apr 15, 2024
src/repository/views.py
Outdated
| @@ -879,9 +880,11 @@ def repository_manager_article(request, preprint_id): | |||
| 'You must assign at least one galley file.', | |||
| ) | |||
| else: | |||
| d = datetime.fromisoformat(request.POST.get('datetime', timezone.now().strftime("%Y-%m-%d %H:%M"))) | |||
There was a problem hiding this comment.
What happens if a malformed date is passed in here?
There was a problem hiding this comment.
@ajrbyers this scenario is unlikely because the form field does inline checking but I added a catch to handle this situation.
|
Dear Mr Jenkins: test this please |
ajrbyers
approved these changes
Apr 19, 2024
mauromsl
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a publication date was selected during preprint acceptance the default date was shown in local time but recorded as if it were in UTC. Add the timezone info to the datetime object created at acceptance.