Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to Janeway documentation #4036

Merged
merged 67 commits into from
May 29, 2024
Merged

Revisions to Janeway documentation #4036

merged 67 commits into from
May 29, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Mar 18, 2024

This branch has a bunch of small changes that Siobhan has made to the docs.

Original description

@S-Haime I am opening a draft pull request for this just so that I can better look at the Git differences and figure out how to form the initial RST merge of workflow guides, as discussed last week.

Also here is an HTML build from 2024-03-18 so you can see the rendered RST. This includes the fixes from #4037. Just download and unzip the zip folder and then open the file index.html in a browser and it should look and act nearly just like janeway.readthedocs.io.

@joemull joemull assigned joemull and S-Haime and unassigned joemull Mar 18, 2024
@mauromsl mauromsl marked this pull request as ready for review May 2, 2024 15:32
@mauromsl mauromsl requested a review from ajrbyers May 2, 2024 15:34
@mauromsl mauromsl assigned ajrbyers and unassigned S-Haime May 2, 2024
@joemull
Copy link
Member Author

joemull commented May 7, 2024

@mauromsl and @ajrbyers I don't think this is ready for review, unless I am out of the loop on the latest plan. It needs a bunch of small fixes from #4037 first. Can we talk about it before merging?

@ajrbyers
Copy link
Member

ajrbyers commented May 7, 2024

Sure thing @joemull. This PR has draft in the title but might be worth marking it as a draft PR.

@joemull
Copy link
Member Author

joemull commented May 7, 2024

@ajrbyers that's why I mention it -- Mauro changed it from draft to ready last week.

@joemull joemull marked this pull request as draft May 7, 2024 09:13
@joemull joemull changed the title Draft of RST merge Revisions to Janeway documentation May 8, 2024
@joemull joemull marked this pull request as ready for review May 8, 2024 09:54
@joemull
Copy link
Member Author

joemull commented May 8, 2024

OK @ajrbyers, it should be ready now.

Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but there is a conflict in installation.md.

@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers and joemull May 28, 2024
@S-Haime
Copy link
Member

S-Haime commented May 28, 2024

Ah it'll be because I put it in the dev folder. If I move it back to where it was hanging out before, will that fix it :) ? @ajrbyers

S-Haime and others added 27 commits May 29, 2024 09:59
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
Test image

Signed-off-by: Siobhan <[email protected]>
Signed-off-by: Siobhan <[email protected]>
@joemull joemull merged commit a0a87f5 into master May 29, 2024
1 check was pending
@joemull joemull deleted the docs-update branch May 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants