Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for displaying issues grouped by decade #3999

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Adds support for displaying issues grouped by decade #3999

merged 9 commits into from
Mar 5, 2024

Conversation

ajrbyers
Copy link
Member

@ajrbyers
Copy link
Member Author

@S-Haime I've added you as a reviewer as I've updated the docs.

joemull
joemull requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I just have some requests about markup and headings.

src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated Show resolved Hide resolved
src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Show resolved Hide resolved
src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated Show resolved Hide resolved
src/themes/OLH/templates/elements/journal/issue_list_by_decade.html Outdated Show resolved Hide resolved
@joemull
Copy link
Member

joemull commented Mar 4, 2024

OK this now has two approvals. @ajrbyers do I need to wait for @S-Haime to review it or go ahead and merge it?

S-Haime
S-Haime approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@S-Haime S-Haime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!
@joemull Apologies, I thought I had already reviewed but must not have saved properly.

@joemull joemull merged commit 4198b03 into master Mar 5, 2024
1 check failed
@joemull joemull deleted the 3276-group_issues_by_year branch March 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

@joemull joemull joemull approved these changes

@S-Haime S-Haime S-Haime approved these changes

@StephDriver StephDriver Awaiting requested review from StephDriver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to group issues by decade
4 participants
@ajrbyers @joemull @mauromsl @S-Haime