#2678 wrapper div of class columns added #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock, as used in other homepage elements
joemull
approved these changes
Mar 7, 2024
ajrbyers
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On investigating, this bug only affected OLH theme.
The about section was unaffected due to padding provided by div class 'columns.'
Added a wrapper div of class columns to the issue_block.html template to gain same affect for this block.
Used a wrapper within homepage element because otherwise this would have required individual changes (e.g. to add this class) to both issue_top and issue_block journal elements which may be re-used elsewhere as not specific to homepage.
Closes #2678