Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CMS templates #3808

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Custom CMS templates #3808

merged 6 commits into from
Jan 29, 2024

Conversation

joemull
Copy link
Member

@joemull joemull commented Dec 6, 2023

Closes #3794

@joemull joemull requested review from ajrbyers and mauromsl December 6, 2023 16:32
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment added, otherwise very good!

@joemull joemull requested a review from ajrbyers January 24, 2024 17:18
@joemull joemull force-pushed the 3794-custom-cms-templates branch from cebcaf1 to cb354ea Compare January 25, 2024 09:57
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a minor comment and I think it would be good to add a TestCase of a CMS page using a custom template

@joemull joemull requested a review from mauromsl January 25, 2024 18:44
@mauromsl mauromsl merged commit f8d76c9 into master Jan 29, 2024
1 check passed
@mauromsl mauromsl deleted the 3794-custom-cms-templates branch January 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

When creating a CMS page, I want to load a Django template
3 participants