Fixed an issue where From address was being encoded as a tuple on some email backends #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we always sanitize the from address before handing it over to the email backend. This will be a redundant call for some backends but will stop the bad encoding on others.
It also avoids sending an empty reply_to header as some very old SMTP servers could have trouble with this.
As a bonus, I added an additional service to docker-compose that allows running the development server against a very simple SMTP server when using the
DEBUG_SMTPflag (e.g:DEBUG_SMTP=1 make runcloses #3545