Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue with full text search compatibility and Django 3.2 #3516

Merged
merged 1 commit into from
May 3, 2023
Merged

Fixes an issue with full text search compatibility and Django 3.2 #3516

merged 1 commit into from
May 3, 2023

Conversation

mauromsl
Copy link
Member

@mauromsl mauromsl commented May 3, 2023

No description provided.

@mauromsl mauromsl requested a review from ajrbyers May 3, 2023 07:24
ajrbyers
ajrbyers approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/core/model_utils.py
(405c8363362063542e9e79beac53c8437d389520) also attempts to cast the
column data into a TextField, prior to casting to the tsvector, which we
override under `set_source_expressions`

"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also in #3515

@mauromsl mauromsl merged commit 4970175 into b_1_5_0 May 3, 2023
@mauromsl mauromsl deleted the fix-full-text-search branch May 3, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajrbyers ajrbyers ajrbyers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauromsl @ajrbyers