RSS feed titles and descriptions are now not terrible. #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrbyers
changed the title
mauromsl
reviewed
Sep 14, 2022
src/rss/views.py
Outdated
Comment on lines
62
to
67
| def title(self, obj): | ||
| return "{} Article Feed".format(obj.name) | ||
|
|
||
| def description(self, obj): | ||
| return "A feed of the 10 latest articles from {}".format(obj.name) | ||
|
|
There was a problem hiding this comment.
can obj be None ? It seems that way from self.get_object, in which case it would raise an AttributeError here
|
jenkins: test this please |
|
Looks like this one is good to go! |
Waiting on Jenkins at the moment, there were a few tests still failing |
Ah, it showed passed to me! |
Shows as pending to me, but you are right, build has passed! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.